Increase timeout for object manager valgrind tests#4027
Increase timeout for object manager valgrind tests#4027pcmoritz merged 4 commits intoray-project:masterfrom
Conversation
| // Ensure timeout_ms = 0 is handled correctly. | ||
| // Out of 5 objects, we expect 3 ready objects and 2 remaining objects. | ||
| TestWait(600, 5, 3, /*timeout_ms=*/0, false, false); | ||
| TestWait(100, 5, 3, /*timeout_ms=*/0, false, false); |
There was a problem hiding this comment.
Is decreasing the object size intentional here?
There was a problem hiding this comment.
Yes, to put it back under the inline objects limit.
There was a problem hiding this comment.
I see, shouldn't we test both?
|
Test FAILed. |
|
Test FAILed. |
guoyuhong
left a comment
guoyuhong
left a comment
There was a problem hiding this comment.
Thanks for fix this! I left a minor comment.
| # Use timeout=1000ms for the Wait tests. | ||
| $CORE_DIR/src/ray/object_manager/object_manager_test $STORE_EXEC 1000 | ||
| # Run tests again with inlined objects. | ||
| $CORE_DIR/src/ray/object_manager/object_manager_test $STORE_EXEC 1000 |
There was a problem hiding this comment.
Why use the same parameters for the same test? Is true missing?
There was a problem hiding this comment.
Ah, thank you! I added it.
|
Test FAILed. |
|
Jenkins retest this please |
|
Test PASSed. |
5 participants
What do these changes do?
Since the inlined objects PR (#3756) was merged, one of the object manager tests was failing on valgrind due to a timing issue. This increases the timeout when running in valgrind.
This also removes an unnecessary data copy when retrieving the inline object data.
Related issue number
Closes #3979.